[Webkit-unassigned] [Bug 164917] [GTK] Crash in WebCore::PlatformDisplayX11::supportsXComposite when running under Wayland

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=164917

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #295415|review?                     |review+
              Flags|                            |

--- Comment #9 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 295415
  --> https://bugs.webkit.org/attachment.cgi?id=295415
Fix EFL build

View in context: https://bugs.webkit.org/attachment.cgi?id=295415&action=review

Thanks.

> Source/WebCore/platform/graphics/PlatformDisplay.h:74
> +    PlatformDisplay(NativeDisplayOwned = NativeDisplayOwned::No);

It doesn't matter much because the constructor is protected and not public, but without the explicit keyword you've created an implicit conversion between NativeDisplayOwned and PlatformDisplay, which is definitely undesired. So please add the explicit keyword before landing. Also, consider getting rid of the default argument. Our code will be more robust to future modification if you have to always pass NativeDisplayOwned when creating the display.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161125/3f1544fa/attachment.html>