<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Crash in WebCore::PlatformDisplayX11::supportsXComposite when running under Wayland"
href="https://bugs.webkit.org/show_bug.cgi?id=164917">bug 164917</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #295415 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Crash in WebCore::PlatformDisplayX11::supportsXComposite when running under Wayland"
href="https://bugs.webkit.org/show_bug.cgi?id=164917#c9">Comment # 9</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Crash in WebCore::PlatformDisplayX11::supportsXComposite when running under Wayland"
href="https://bugs.webkit.org/show_bug.cgi?id=164917">bug 164917</a>
from <span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=295415&action=diff" name="attach_295415" title="Fix EFL build">attachment 295415</a> <a href="attachment.cgi?id=295415&action=edit" title="Fix EFL build">[details]</a></span>
Fix EFL build
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=295415&action=review">https://bugs.webkit.org/attachment.cgi?id=295415&action=review</a>
Thanks.
<span class="quote">> Source/WebCore/platform/graphics/PlatformDisplay.h:74
> + PlatformDisplay(NativeDisplayOwned = NativeDisplayOwned::No);</span >
It doesn't matter much because the constructor is protected and not public, but without the explicit keyword you've created an implicit conversion between NativeDisplayOwned and PlatformDisplay, which is definitely undesired. So please add the explicit keyword before landing. Also, consider getting rid of the default argument. Our code will be more robust to future modification if you have to always pass NativeDisplayOwned when creating the display.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>