[Webkit-unassigned] [Bug 164922] [SOUP] Simplify custom protocols handler implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=164922

--- Comment #17 from Darin Adler <darin at apple.com> ---
Comment on attachment 295159
  --> https://bugs.webkit.org/attachment.cgi?id=295159
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=295159&action=review

There’s s surprising amount of SOUP-specific #if in all these classes. As a direction for WebKit2 seems like a step in the wrong direction; would be nice to find a more elegant way of doing it.

But I approve of landing it as is.

> Source/WebKit2/UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.h:67
> +#if USE(SOUP)
> +    void didReceiveResponse(uint64_t customProtocolID, const WebCore::ResourceResponse&);
> +    void didLoadData(uint64_t customProtocolID, const IPC::DataReference&);
> +    void didFailWithError(uint64_t customProtocolID, const WebCore::ResourceError&);
> +    void didFinishLoading(uint64_t customProtocolID);
> +#endif

This doesn’t seem quite right to me; I don’t have strong objections to landing it, but it seems like the wrong direction long term. The people I would ask about alternatives are Sam and Anders.

> Source/WebKit2/UIProcess/WebProcessPool.h:140
> +    void setCustomProtocolManagerClient(std::unique_ptr<API::CustomProtocolManagerClient>);

A function like this should take unique_ptr&&, not just unique_ptr. See <http://scottmeyers.blogspot.com/2014/07/should-move-only-types-ever-be-passed.html> for one version of the rationale.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161121/ebc0ed40/attachment-0001.html>