<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [SOUP] Simplify custom protocols handler implementation"
href="https://bugs.webkit.org/show_bug.cgi?id=164922#c17">Comment # 17</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [SOUP] Simplify custom protocols handler implementation"
href="https://bugs.webkit.org/show_bug.cgi?id=164922">bug 164922</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=295159&action=diff" name="attach_295159" title="Patch">attachment 295159</a> <a href="attachment.cgi?id=295159&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=295159&action=review">https://bugs.webkit.org/attachment.cgi?id=295159&action=review</a>
There’s s surprising amount of SOUP-specific #if in all these classes. As a direction for WebKit2 seems like a step in the wrong direction; would be nice to find a more elegant way of doing it.
But I approve of landing it as is.
<span class="quote">> Source/WebKit2/UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.h:67
> +#if USE(SOUP)
> + void didReceiveResponse(uint64_t customProtocolID, const WebCore::ResourceResponse&);
> + void didLoadData(uint64_t customProtocolID, const IPC::DataReference&);
> + void didFailWithError(uint64_t customProtocolID, const WebCore::ResourceError&);
> + void didFinishLoading(uint64_t customProtocolID);
> +#endif</span >
This doesn’t seem quite right to me; I don’t have strong objections to landing it, but it seems like the wrong direction long term. The people I would ask about alternatives are Sam and Anders.
<span class="quote">> Source/WebKit2/UIProcess/WebProcessPool.h:140
> + void setCustomProtocolManagerClient(std::unique_ptr<API::CustomProtocolManagerClient>);</span >
A function like this should take unique_ptr&&, not just unique_ptr. See <<a href="http://scottmeyers.blogspot.com/2014/07/should-move-only-types-ever-be-passed.html">http://scottmeyers.blogspot.com/2014/07/should-move-only-types-ever-be-passed.html</a>> for one version of the rationale.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>