[Webkit-unassigned] [Bug 164937] [cmake][OpenWebRTC] Move SDPProcessorScriptResource to GStreamer directory

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 18 15:14:19 PST 2016


--- Comment #3 from Olivier Blin <olivier.blin at softathome.com> ---
(In reply to comment #2)
> Modules/mediastream/sdp.js is certainly not specific to GStreamer, it used
> used by Mac port too, so it should be moved to WebCore/CMakeLists.txt
> I assume the same is true for SDPProcessorScriptResource.cpp, just nobody
> took care to fix building MediaStream in Mac port with cmake.

Actually, it seems the SDP dependencies are wrong.
It lists Source/WebCore/platform/mediastream/openwebrtc/SDPProcessorScriptResource.cpp, but the file is no actually in the Source/WebCore/platform/mediastream/ directory (moved by Youenn in bug 163940, which is about fixing the Mac bots).

So, instead of moving the cmake rules to the gstreamer directory, we should actually move them into the main WebCore/CMakeLists.txt, as you suggests.

Thanks for the review

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161118/8cebb4f6/attachment-0001.html>

More information about the webkit-unassigned mailing list