<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [cmake][OpenWebRTC] Move SDPProcessorScriptResource to GStreamer directory"
href="https://bugs.webkit.org/show_bug.cgi?id=164937#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [cmake][OpenWebRTC] Move SDPProcessorScriptResource to GStreamer directory"
href="https://bugs.webkit.org/show_bug.cgi?id=164937">bug 164937</a>
from <span class="vcard"><a class="email" href="mailto:olivier.blin@softathome.com" title="Olivier Blin <olivier.blin@softathome.com>"> <span class="fn">Olivier Blin</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=164937#c2">comment #2</a>)
<span class="quote">> Modules/mediastream/sdp.js is certainly not specific to GStreamer, it used
> used by Mac port too, so it should be moved to WebCore/CMakeLists.txt
>
> I assume the same is true for SDPProcessorScriptResource.cpp, just nobody
> took care to fix building MediaStream in Mac port with cmake.</span >
Actually, it seems the SDP dependencies are wrong.
It lists Source/WebCore/platform/mediastream/openwebrtc/SDPProcessorScriptResource.cpp, but the file is no actually in the Source/WebCore/platform/mediastream/ directory (moved by Youenn in <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Enable SDPProcessor for Mac bots"
href="show_bug.cgi?id=163940">bug 163940</a>, which is about fixing the Mac bots).
So, instead of moving the cmake rules to the gstreamer directory, we should actually move them into the main WebCore/CMakeLists.txt, as you suggests.
Thanks for the review</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>