[Webkit-unassigned] [Bug 164922] [SOUP] Simplify custom protocols handler implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=164922

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #295159|review?                     |review+
              Flags|                            |

--- Comment #12 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 295159
  --> https://bugs.webkit.org/attachment.cgi?id=295159
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=295159&action=review

r=me on the GTK+ and EFL changes. I think an owner should take a quick look at the CustomProtocolManagerProxy and WebProcessPool changes, even though the changes are all in #ifdefs, just in case of design objection.

> Source/WebKit2/UIProcess/API/efl/ewk_url_scheme_request_private.h:59
> +    WebKit::CustomProtocolManagerProxy* manager() const { return m_wkRequestManager; }

The return value here should be a const pointer. If you need to return a non-const pointer, then you should add an overload that is not a const member function.

> Source/WebKit2/UIProcess/WebProcessPool.cpp:-170
> -#if USE(SOUP)
> -    , m_initialHTTPCookieAcceptPolicy(HTTPCookieAcceptPolicyOnlyFromMainDocumentDomain)
> -#endif

This patch is big and confusing enough that I would prefer to do this in a separate patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161118/da8088a0/attachment.html>