<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [SOUP] Simplify custom protocols handler implementation"
href="https://bugs.webkit.org/show_bug.cgi?id=164922">bug 164922</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #295159 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [SOUP] Simplify custom protocols handler implementation"
href="https://bugs.webkit.org/show_bug.cgi?id=164922#c12">Comment # 12</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [SOUP] Simplify custom protocols handler implementation"
href="https://bugs.webkit.org/show_bug.cgi?id=164922">bug 164922</a>
from <span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=295159&action=diff" name="attach_295159" title="Patch">attachment 295159</a> <a href="attachment.cgi?id=295159&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=295159&action=review">https://bugs.webkit.org/attachment.cgi?id=295159&action=review</a>
r=me on the GTK+ and EFL changes. I think an owner should take a quick look at the CustomProtocolManagerProxy and WebProcessPool changes, even though the changes are all in #ifdefs, just in case of design objection.
<span class="quote">> Source/WebKit2/UIProcess/API/efl/ewk_url_scheme_request_private.h:59
> + WebKit::CustomProtocolManagerProxy* manager() const { return m_wkRequestManager; }</span >
The return value here should be a const pointer. If you need to return a non-const pointer, then you should add an overload that is not a const member function.
<span class="quote">> Source/WebKit2/UIProcess/WebProcessPool.cpp:-170
> -#if USE(SOUP)
> - , m_initialHTTPCookieAcceptPolicy(HTTPCookieAcceptPolicyOnlyFromMainDocumentDomain)
> -#endif</span >
This patch is big and confusing enough that I would prefer to do this in a separate patch.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>