[Webkit-unassigned] [Bug 164364] Downloads started by context menu actions should also have a web view associated

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=164364

--- Comment #6 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #3)
> Comment on attachment 293758 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=293758&action=review
> 
> > Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:1237
> > +    return download.leakRef();
> 
> Where is this ref adopted? Normally we leave a comment in situations like
> this.

This is returned by public API in transfer-full methods. To clarify it, instead of adding a comment, I've changed it to leak the ref from webkit_web_context_download_uri() and webkit_web_view_download_uri().

> > Source/WebKit2/UIProcess/WebProcessPool.cpp:816
> > +    if (initiatingPage)
> > +        initiatingPage->handleDownloadRequest(downloadProxy);
> 
> We need an owner to approve this part. Alex?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161118/c7914952/attachment-0001.html>