<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Downloads started by context menu actions should also have a web view associated"
href="https://bugs.webkit.org/show_bug.cgi?id=164364#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Downloads started by context menu actions should also have a web view associated"
href="https://bugs.webkit.org/show_bug.cgi?id=164364">bug 164364</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=164364#c3">comment #3</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=293758&action=diff" name="attach_293758" title="Patch">attachment 293758</a> <a href="attachment.cgi?id=293758&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=293758&action=review">https://bugs.webkit.org/attachment.cgi?id=293758&action=review</a>
>
> > Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:1237
> > + return download.leakRef();
>
> Where is this ref adopted? Normally we leave a comment in situations like
> this.</span >
This is returned by public API in transfer-full methods. To clarify it, instead of adding a comment, I've changed it to leak the ref from webkit_web_context_download_uri() and webkit_web_view_download_uri().
<span class="quote">> > Source/WebKit2/UIProcess/WebProcessPool.cpp:816
> > + if (initiatingPage)
> > + initiatingPage->handleDownloadRequest(downloadProxy);
>
> We need an owner to approve this part. Alex?</span ></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>