[Webkit-unassigned] [Bug 164864] REGRESSION(r208511): ImageDecoders: Crash decoding GIF images since r208511

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=164864

--- Comment #6 from Said Abou-Hallawa <sabouhallawa at apple.com> ---
Comment on attachment 295048
  --> https://bugs.webkit.org/attachment.cgi?id=295048
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=295048&action=review

Would it be better to rename the existing virtual frameBufferAtIndex() functions to be internalFrameBufferAtIndex() and create a non virtual function called frameBufferAtIndex() in imageDecoder class which does the locking and call internalFrameBufferAtIndex()?

> Source/WebCore/platform/image-decoders/ImageDecoder.cpp:174
> +    Locker<Lock> locker(m_lock);

You can use LockHolder instead of Locker<Lock>.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161117/63510a0f/attachment.html>