<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - REGRESSION(r208511): ImageDecoders: Crash decoding GIF images since r208511"
href="https://bugs.webkit.org/show_bug.cgi?id=164864#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - REGRESSION(r208511): ImageDecoders: Crash decoding GIF images since r208511"
href="https://bugs.webkit.org/show_bug.cgi?id=164864">bug 164864</a>
from <span class="vcard"><a class="email" href="mailto:sabouhallawa@apple.com" title="Said Abou-Hallawa <sabouhallawa@apple.com>"> <span class="fn">Said Abou-Hallawa</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=295048&action=diff" name="attach_295048" title="Patch">attachment 295048</a> <a href="attachment.cgi?id=295048&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=295048&action=review">https://bugs.webkit.org/attachment.cgi?id=295048&action=review</a>
Would it be better to rename the existing virtual frameBufferAtIndex() functions to be internalFrameBufferAtIndex() and create a non virtual function called frameBufferAtIndex() in imageDecoder class which does the locking and call internalFrameBufferAtIndex()?
<span class="quote">> Source/WebCore/platform/image-decoders/ImageDecoder.cpp:174
> + Locker<Lock> locker(m_lock);</span >
You can use LockHolder instead of Locker<Lock>.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>