[Webkit-unassigned] [Bug 164864] REGRESSION(r208511): ImageDecoders: Crash decoding GIF images since r208511

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=164864

--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #3)
> Comment on attachment 295048 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=295048&action=review

Thanks for the review.

> > Source/WebCore/ChangeLog:8
> > +        This happens sometimes since r208511 because the same decoder is decoded by more than one thread at the same
> 
> same decoder is decoded by -> same decoder is used by

Oops.

> > Source/WebCore/platform/image-decoders/ImageDecoder.h:218
> > +        Lock m_lock;
> 
> Would be nice to name this so that it indicates what it protects.

Actually I named this m_decoderLock at first, but sounded redundant to me because the class is ImageDecoder. Maybe m_decodeLock, since we are protecting the decode() method in the end.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161117/c16cbe34/attachment-0001.html>