<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - REGRESSION(r208511): ImageDecoders: Crash decoding GIF images since r208511"
href="https://bugs.webkit.org/show_bug.cgi?id=164864#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - REGRESSION(r208511): ImageDecoders: Crash decoding GIF images since r208511"
href="https://bugs.webkit.org/show_bug.cgi?id=164864">bug 164864</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=164864#c3">comment #3</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=295048&action=diff" name="attach_295048" title="Patch">attachment 295048</a> <a href="attachment.cgi?id=295048&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=295048&action=review">https://bugs.webkit.org/attachment.cgi?id=295048&action=review</a></span >
Thanks for the review.
<span class="quote">> > Source/WebCore/ChangeLog:8
> > + This happens sometimes since r208511 because the same decoder is decoded by more than one thread at the same
>
> same decoder is decoded by -> same decoder is used by</span >
Oops.
<span class="quote">> > Source/WebCore/platform/image-decoders/ImageDecoder.h:218
> > + Lock m_lock;
>
> Would be nice to name this so that it indicates what it protects.</span >
Actually I named this m_decoderLock at first, but sounded redundant to me because the class is ImageDecoder. Maybe m_decodeLock, since we are protecting the decode() method in the end.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>