[Webkit-unassigned] [Bug 153828] [Gstreamer] Add volume and mute support to the WebRTC mediaplayer

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 14 09:33:16 PST 2016


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
 Attachment #294703|review?                     |review+
              Flags|                            |

--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 294703
  --> https://bugs.webkit.org/attachment.cgi?id=294703
[OpenWebRTC] audio mute/volume support

View in context: https://bugs.webkit.org/attachment.cgi?id=294703&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.cpp:108
> +    if (!m_audioTrack)
> +        return;
> +
> +

Extra blank line here.

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.cpp:109
> +    auto realTimeMediaSource = reinterpret_cast<RealtimeMediaSourceOwr*>(&m_audioTrack->source());

Having to use reinterpret_cast is usually a major danger sign; is there a way to use static_cast in the three places in this file instead?

I suggest making this be a reference instead of a pointer:

    auto& realTimeMediaSource = *some_kind_of_cast<RealtimeMediaSourceOwr&>(m_audioTrack->source());

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.h:77
> +    void setVolume(float) override;
> +    void setMuted(bool) override;

final instead of override?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161114/1a13c150/attachment.html>

More information about the webkit-unassigned mailing list