<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [Gstreamer] Add volume and mute support to the WebRTC mediaplayer"
href="https://bugs.webkit.org/show_bug.cgi?id=153828">bug 153828</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #294703 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [Gstreamer] Add volume and mute support to the WebRTC mediaplayer"
href="https://bugs.webkit.org/show_bug.cgi?id=153828#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [Gstreamer] Add volume and mute support to the WebRTC mediaplayer"
href="https://bugs.webkit.org/show_bug.cgi?id=153828">bug 153828</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=294703&action=diff" name="attach_294703" title="[OpenWebRTC] audio mute/volume support">attachment 294703</a> <a href="attachment.cgi?id=294703&action=edit" title="[OpenWebRTC] audio mute/volume support">[details]</a></span>
[OpenWebRTC] audio mute/volume support
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=294703&action=review">https://bugs.webkit.org/attachment.cgi?id=294703&action=review</a>
<span class="quote">> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.cpp:108
> + if (!m_audioTrack)
> + return;
> +
> +</span >
Extra blank line here.
<span class="quote">> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.cpp:109
> + auto realTimeMediaSource = reinterpret_cast<RealtimeMediaSourceOwr*>(&m_audioTrack->source());</span >
Having to use reinterpret_cast is usually a major danger sign; is there a way to use static_cast in the three places in this file instead?
I suggest making this be a reference instead of a pointer:
auto& realTimeMediaSource = *some_kind_of_cast<RealtimeMediaSourceOwr&>(m_audioTrack->source());
<span class="quote">> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.h:77
> + void setVolume(float) override;
> + void setMuted(bool) override;</span >
final instead of override?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>