[Webkit-unassigned] [Bug 43239] Support for HTML Media Capture API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43239

--- Comment #16 from Tim Horton <thorton at apple.com> ---
Comment on attachment 294532
  --> https://bugs.webkit.org/attachment.cgi?id=294532
Proposed patch v3

View in context: https://bugs.webkit.org/attachment.cgi?id=294532&action=review

> Source/WebKit2/UIProcess/Cocoa/WKUserMediaProviderCocoa.h:42
> +class WKUserMediaProviderCocoa final : public WKUserMediaProvider {

No WK prefix here either.

> Source/WebKit2/UIProcess/Cocoa/WKUserMediaProviderCocoa.mm:86
> +    void (^cameraAuthorizationBlock)(void) = ^ {
> +        if (requiresVideo) {
> +            [captureDeviceAuthorizer() requestCameraAuthorization:^(BOOL authorized) {

I think instead of this mechanism, this should be the default implementation of the UIDelegate, perhaps.

> Source/WebKit2/WebKit2.xcodeproj/project.pbxproj:3265
> -		7CB16FE41724B9B5007A0A95 /* com.apple.WebKit.plugin-common.sb.in */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; name = "com.apple.WebKit.plugin-common.sb.in"; sourceTree = "<group>"; };
> +		7CB16FE41724B9B5007A0A95 /* com.apple.WebKit.plugin-common.sb.in */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; path = "com.apple.WebKit.plugin-common.sb.in"; sourceTree = "<group>"; };

This shouldn't be in this patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161111/931c6374/attachment-0001.html>