<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Support for HTML Media Capture API"
href="https://bugs.webkit.org/show_bug.cgi?id=43239#c16">Comment # 16</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Support for HTML Media Capture API"
href="https://bugs.webkit.org/show_bug.cgi?id=43239">bug 43239</a>
from <span class="vcard"><a class="email" href="mailto:thorton@apple.com" title="Tim Horton <thorton@apple.com>"> <span class="fn">Tim Horton</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=294532&action=diff" name="attach_294532" title="Proposed patch v3">attachment 294532</a> <a href="attachment.cgi?id=294532&action=edit" title="Proposed patch v3">[details]</a></span>
Proposed patch v3
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=294532&action=review">https://bugs.webkit.org/attachment.cgi?id=294532&action=review</a>
<span class="quote">> Source/WebKit2/UIProcess/Cocoa/WKUserMediaProviderCocoa.h:42
> +class WKUserMediaProviderCocoa final : public WKUserMediaProvider {</span >
No WK prefix here either.
<span class="quote">> Source/WebKit2/UIProcess/Cocoa/WKUserMediaProviderCocoa.mm:86
> + void (^cameraAuthorizationBlock)(void) = ^ {
> + if (requiresVideo) {
> + [captureDeviceAuthorizer() requestCameraAuthorization:^(BOOL authorized) {</span >
I think instead of this mechanism, this should be the default implementation of the UIDelegate, perhaps.
<span class="quote">> Source/WebKit2/WebKit2.xcodeproj/project.pbxproj:3265
> - 7CB16FE41724B9B5007A0A95 /* com.apple.WebKit.plugin-common.sb.in */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; name = "com.apple.WebKit.plugin-common.sb.in"; sourceTree = "<group>"; };
> + 7CB16FE41724B9B5007A0A95 /* com.apple.WebKit.plugin-common.sb.in */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; path = "com.apple.WebKit.plugin-common.sb.in"; sourceTree = "<group>"; };</span >
This shouldn't be in this patch.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>