[Webkit-unassigned] [Bug 160864] Shadow DOM: Toggling class in `.class ::slotted(*)` does not trigger style recalc

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=160864

Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #294518|review?                     |review+
              Flags|                            |

--- Comment #6 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 294518
  --> https://bugs.webkit.org/attachment.cgi?id=294518
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=294518&action=review

>>> Source/WebCore/css/StyleInvalidationAnalysis.cpp:114
>>> +        m_didInvalidateHostChildren = true;
>> 
>> It seems like we don't need to set m_didInvalidateHostChildren if the slot isn't in a shadow tree?
>> Or is this a kind of optimization to avoid checking whether element is in the shadow tree or not?
> 
> It is used to avoid O(slots*host children) traversal if there are tons of slots/children.

Might be worth a comment. Otherwise, someone might come around and *fix* it.

> LayoutTests/fast/shadow-dom/css-scoping-host-and-slotted-context-invalidation.html:81
> +

Can we add a test case with multiple slots in a single shadow tree?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161111/c9790bdd/attachment.html>