<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:rniwa@webkit.org" title="Ryosuke Niwa <rniwa@webkit.org>"> <span class="fn">Ryosuke Niwa</span></a>
</span> changed
<a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - Shadow DOM: Toggling class in `.class ::slotted(*)` does not trigger style recalc"
href="https://bugs.webkit.org/show_bug.cgi?id=160864">bug 160864</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #294518 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - Shadow DOM: Toggling class in `.class ::slotted(*)` does not trigger style recalc"
href="https://bugs.webkit.org/show_bug.cgi?id=160864#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - Shadow DOM: Toggling class in `.class ::slotted(*)` does not trigger style recalc"
href="https://bugs.webkit.org/show_bug.cgi?id=160864">bug 160864</a>
from <span class="vcard"><a class="email" href="mailto:rniwa@webkit.org" title="Ryosuke Niwa <rniwa@webkit.org>"> <span class="fn">Ryosuke Niwa</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=294518&action=diff" name="attach_294518" title="patch">attachment 294518</a> <a href="attachment.cgi?id=294518&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=294518&action=review">https://bugs.webkit.org/attachment.cgi?id=294518&action=review</a>
<span class="quote">>>> Source/WebCore/css/StyleInvalidationAnalysis.cpp:114
>>> + m_didInvalidateHostChildren = true;
>>
>> It seems like we don't need to set m_didInvalidateHostChildren if the slot isn't in a shadow tree?
>> Or is this a kind of optimization to avoid checking whether element is in the shadow tree or not?
>
> It is used to avoid O(slots*host children) traversal if there are tons of slots/children.</span >
Might be worth a comment. Otherwise, someone might come around and *fix* it.
<span class="quote">> LayoutTests/fast/shadow-dom/css-scoping-host-and-slotted-context-invalidation.html:81
> +</span >
Can we add a test case with multiple slots in a single shadow tree?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>