[Webkit-unassigned] [Bug 164490] [Cocoa] Support wide gamut for Drag Image UI

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 11 10:32:58 PST 2016


Tim Horton <thorton at apple.com> changed:

           What    |Removed                     |Added
 Attachment #294446|review?, commit-queue?      |review+, commit-queue+
              Flags|                            |

--- Comment #9 from Tim Horton <thorton at apple.com> ---
Comment on attachment 294446
  --> https://bugs.webkit.org/attachment.cgi?id=294446

View in context: https://bugs.webkit.org/attachment.cgi?id=294446&action=review

> Source/WebCore/ChangeLog:8
> +        Fixed an error in the support define for wide gamut on Mac.

Maybe "use extended sRGB on macOS Sierra"? Or some such.

> Source/WebKit2/ChangeLog:8
> +        Fixed an error in the gating for the new wide gamut support in ShareableBitmap.


> Source/WebKit2/ChangeLog:9
> +        We should always respect the flags straight out, and not make decisions later, it can lead to mismatched data and data storage.

Maybe "Always respect the stored extended color flag instead of re-computing whether a buffer should use extended color." or something?

> Source/WebKit2/WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:59
> +    if (screenSupportsExtendedColor(frame.mainFrame().view()))

is screenSupportsExtendedColor actually *any*ScreenSupportsExtendedColor? Otherwise, what if you drag from a sRGB to P3 display?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161111/1e480b54/attachment.html>

More information about the webkit-unassigned mailing list