<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:thorton@apple.com" title="Tim Horton <thorton@apple.com>"> <span class="fn">Tim Horton</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [Cocoa] Support wide gamut for Drag Image UI"
href="https://bugs.webkit.org/show_bug.cgi?id=164490">bug 164490</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #294446 Flags</td>
<td>review?, commit-queue?
</td>
<td>review+, commit-queue+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [Cocoa] Support wide gamut for Drag Image UI"
href="https://bugs.webkit.org/show_bug.cgi?id=164490#c9">Comment # 9</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [Cocoa] Support wide gamut for Drag Image UI"
href="https://bugs.webkit.org/show_bug.cgi?id=164490">bug 164490</a>
from <span class="vcard"><a class="email" href="mailto:thorton@apple.com" title="Tim Horton <thorton@apple.com>"> <span class="fn">Tim Horton</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=294446&action=diff" name="attach_294446" title="Patch">attachment 294446</a> <a href="attachment.cgi?id=294446&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=294446&action=review">https://bugs.webkit.org/attachment.cgi?id=294446&action=review</a>
<span class="quote">> Source/WebCore/ChangeLog:8
> + Fixed an error in the support define for wide gamut on Mac.</span >
Maybe "use extended sRGB on macOS Sierra"? Or some such.
<span class="quote">> Source/WebKit2/ChangeLog:8
> + Fixed an error in the gating for the new wide gamut support in ShareableBitmap.</span >
?
<span class="quote">> Source/WebKit2/ChangeLog:9
> + We should always respect the flags straight out, and not make decisions later, it can lead to mismatched data and data storage.</span >
Maybe "Always respect the stored extended color flag instead of re-computing whether a buffer should use extended color." or something?
<span class="quote">> Source/WebKit2/WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:59
> + if (screenSupportsExtendedColor(frame.mainFrame().view()))</span >
is screenSupportsExtendedColor actually *any*ScreenSupportsExtendedColor? Otherwise, what if you drag from a sRGB to P3 display?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>