[Webkit-unassigned] [Bug 161481] [GTK] Use GTestDBus instead of dbus-launch in WebKitTestBus.cpp

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 1 05:10:24 PDT 2016


--- Comment #8 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 293416
  --> https://bugs.webkit.org/attachment.cgi?id=293416

The problem is that if you do that, the test will randomly crash; we don't need more flaky tests. In fact, since g_test_dbus_up() calls setenv() itself, it suffers from the same problem. We need to be careful to only call such functions (a) at the very top of main(), or (b) when we're really really sure that it's before the first secondary thread has been created, otherwise the test will be flaky. And it's impossible for WebKitTestBus to guarantee where it's used from, so it really needs to not be setting environment variables.

Is it even possible to create a GObject without starting secondary threads?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161101/4a66ac5e/attachment.html>

More information about the webkit-unassigned mailing list