<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Use GTestDBus instead of dbus-launch in WebKitTestBus.cpp"
href="https://bugs.webkit.org/show_bug.cgi?id=161481#c8">Comment # 8</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Use GTestDBus instead of dbus-launch in WebKitTestBus.cpp"
href="https://bugs.webkit.org/show_bug.cgi?id=161481">bug 161481</a>
from <span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=293416&action=diff" name="attach_293416" title="Patch">attachment 293416</a> <a href="attachment.cgi?id=293416&action=edit" title="Patch">[details]</a></span>
Patch
The problem is that if you do that, the test will randomly crash; we don't need more flaky tests. In fact, since g_test_dbus_up() calls setenv() itself, it suffers from the same problem. We need to be careful to only call such functions (a) at the very top of main(), or (b) when we're really really sure that it's before the first secondary thread has been created, otherwise the test will be flaky. And it's impossible for WebKitTestBus to guarantee where it's used from, so it really needs to not be setting environment variables.
Is it even possible to create a GObject without starting secondary threads?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>