[Webkit-unassigned] [Bug 161481] [GTK] Use GTestDBus instead of dbus-launch in WebKitTestBus.cpp

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 1 02:31:38 PDT 2016


Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
 Attachment #293416|review-                     |review?
              Flags|                            |

--- Comment #7 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 293416
  --> https://bugs.webkit.org/attachment.cgi?id=293416

View in context: https://bugs.webkit.org/attachment.cgi?id=293416&action=review

>> Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp:38
>> +    g_setenv("DISPLAY", display.data(), FALSE);
> So the problem here is it's too late to be doing setenv; we've already initialized threads. Some other thread could call getenv at the same time -- there are getenv calls in many many places -- and crash. It's not a theoretical issue, I've seen multiple cases of this crashing gnome-session.

It's not that I want to se the display here, DISPLAY has already been set, but g_test_dbus_up() unsets it unconditionally, so I'm just restoring it because otherwise nothing works (the web process needs DISPLAY to be set to work). This has nothing to do with gnome-session, this only affects the tests.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20161101/f4d7d678/attachment-0001.html>

More information about the webkit-unassigned mailing list