<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Use GTestDBus instead of dbus-launch in WebKitTestBus.cpp"
href="https://bugs.webkit.org/show_bug.cgi?id=161481">bug 161481</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #293416 Flags</td>
<td>review-
</td>
<td>review?
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Use GTestDBus instead of dbus-launch in WebKitTestBus.cpp"
href="https://bugs.webkit.org/show_bug.cgi?id=161481#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Use GTestDBus instead of dbus-launch in WebKitTestBus.cpp"
href="https://bugs.webkit.org/show_bug.cgi?id=161481">bug 161481</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=293416&action=diff" name="attach_293416" title="Patch">attachment 293416</a> <a href="attachment.cgi?id=293416&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=293416&action=review">https://bugs.webkit.org/attachment.cgi?id=293416&action=review</a>
<span class="quote">>> Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp:38
>> + g_setenv("DISPLAY", display.data(), FALSE);
>
> So the problem here is it's too late to be doing setenv; we've already initialized threads. Some other thread could call getenv at the same time -- there are getenv calls in many many places -- and crash. It's not a theoretical issue, I've seen multiple cases of this crashing gnome-session.</span >
It's not that I want to se the display here, DISPLAY has already been set, but g_test_dbus_up() unsets it unconditionally, so I'm just restoring it because otherwise nothing works (the web process needs DISPLAY to be set to work). This has nothing to do with gnome-session, this only affects the tests.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>