No subject

Tue May 3 15:05:30 PDT 2016

<span class="quote">&gt; Tools/Scripts/webkitpy/port/
&gt; +        read_line = spindump_process.stdout.readline()
&gt; +        while read_line:
&gt; +            if read_line:
&gt; +                _log.debug(read_line)
&gt; +            read_line = spindump_process.stdout.readline()</span >

We should be using Executive.run_command() or Executive.run_and_throw_if_fail() to run this command (with the executive object on the port object) instead of using subprocess directly. Unless you feel that the messages emitted by spindump(8) to explain each step that it is performing is beneficial, I would use Executive.run_command() and pass return_exit_code=True to avoid capturing any standard output.</pre>
      <span>You are receiving this mail because:</span>
          <li>You are the assignee for the bug.</li>

More information about the webkit-unassigned mailing list