No subject

Tue May 3 15:05:30 PDT 2016

> Tools/Scripts/webkitpy/port/ios.py:439
> +        read_line = spindump_process.stdout.readline()
> +        while read_line:
> +            if read_line:
> +                _log.debug(read_line)
> +            read_line = spindump_process.stdout.readline()

We should be using Executive.run_command() or Executive.run_and_throw_if_fail() to run this command (with the executive object on the port object) instead of using subprocess directly. Unless you feel that the messages emitted by spindump(8) to explain each step that it is performing is beneficial, I would use Executive.run_command() and pass return_exit_code=True to avoid capturing any standard output.

-- 
You are receiving this mail because:
You are the assignee for the bug.
--1468982824.3EcF408.6768
Date: Tue, 19 Jul 2016 19:47:04 -0700
MIME-Version: 1.0
Content-Type: text/html

<html>
    <head>
      <base href="https://bugs.webkit.org/" />
    </head>
    <body>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - run-webkit-tests should trigger a spindump when WebContent process is unresponsive"
   href="https://bugs.webkit.org/show_bug.cgi?id=159827#c14">Comment # 14</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - run-webkit-tests should trigger a spindump when WebContent process is unresponsive"
   href="https://bugs.webkit.org/show_bug.cgi?id=159827">bug 159827</a>
              from <span class="vcard"><a class="email" href="mailto:dbates&#64;webkit.org" title="Daniel Bates &lt;dbates&#64;webkit.org&gt;"> <span class="fn">Daniel Bates</span></a>
</span></b>
        <pre>Comment on <span class=""><a href="attachment.cgi?id=284062&amp;action=diff" name="attach_284062" title="Patch">attachment 284062</a> <a href="attachment.cgi?id=284062&amp;action=edit" title="Patch">[details]</a></span>
Patch

View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=284062&amp;action=review">https://bugs.webkit.org/attachment.cgi?id=284062&amp;action=review</a>

<span class="quote">&gt; Tools/Scripts/webkitpy/port/ios.py:434
&gt; +        spindump_process = subprocess.Popen(['sudo', '-A', 'spindump', str(pid), '10', '-file', self.results_directory() + '/' + parsed_filename + '.spindump.txt'], stdout=subprocess.PIPE, stderr=subprocess.STDOUT)</span >

Can we make use of option -n instead of -A to have sudo exit with an error if the command requires a password?