[Webkit-unassigned] [Bug 156147] [JSC] implement async functions proposal

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat May 28 09:26:25 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=156147

--- Comment #105 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 280020
  --> https://bugs.webkit.org/attachment.cgi?id=280020
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=280020&action=review

I don't think we should land patches where we have these known regressions. Can we try to get rid of the regressions?

> Source/JavaScriptCore/parser/Parser.cpp:624
> +        if (UNLIKELY(m_runtimeFlags.isAsyncAwaitEnabled() && matchContextualKeyword(m_vm->propertyNames->async))) {

There is a chance that this may be faster if the LHS and RHS were swapped because it might aid the register allocator. 
Same with the similar compare elsewhere.
Is this what's slowing down the parser?
Have you tried making ASYNC a key word? That may be faster than checking the IDENT's StringImpl

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160528/f1d906f7/attachment.html>


More information about the webkit-unassigned mailing list