<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [JSC] implement async functions proposal"
href="https://bugs.webkit.org/show_bug.cgi?id=156147#c105">Comment # 105</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [JSC] implement async functions proposal"
href="https://bugs.webkit.org/show_bug.cgi?id=156147">bug 156147</a>
from <span class="vcard"><a class="email" href="mailto:sbarati@apple.com" title="Saam Barati <sbarati@apple.com>"> <span class="fn">Saam Barati</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=280020&action=diff" name="attach_280020" title="Patch">attachment 280020</a> <a href="attachment.cgi?id=280020&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=280020&action=review">https://bugs.webkit.org/attachment.cgi?id=280020&action=review</a>
I don't think we should land patches where we have these known regressions. Can we try to get rid of the regressions?
<span class="quote">> Source/JavaScriptCore/parser/Parser.cpp:624
> + if (UNLIKELY(m_runtimeFlags.isAsyncAwaitEnabled() && matchContextualKeyword(m_vm->propertyNames->async))) {</span >
There is a chance that this may be faster if the LHS and RHS were swapped because it might aid the register allocator.
Same with the similar compare elsewhere.
Is this what's slowing down the parser?
Have you tried making ASYNC a key word? That may be faster than checking the IDENT's StringImpl</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>