[Webkit-unassigned] [Bug 157988] Preload single download tests.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=157988

--- Comment #7 from Yoav Weiss <yoav at yoav.ws> ---
(In reply to comment #5)
> Comment on attachment 279872 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=279872&action=review
> 
> > LayoutTests/http/tests/preload/resources/single_download_preload.html:44
> > +<span>PASS - this text is here just so that the browser will download the font.</span>
> 
> I'm not sure PASS is a good thing to have here.

Removed it

> 
> > LayoutTests/http/tests/preload/single_download_preload_runner.html:13
> > +        assert_equals(data, 10);
> 
> Is there a way to have this print something to the expectations?  This value
> is what the test is confirming, and it's hard to tell just by glancing at
> the test.

Actually the expectation is not needed for testharness tests. I deleted it and added a description on the assert. Let me know if it's clear enough.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160526/05cd2bd1/attachment.html>