<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Preload single download tests."
href="https://bugs.webkit.org/show_bug.cgi?id=157988#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Preload single download tests."
href="https://bugs.webkit.org/show_bug.cgi?id=157988">bug 157988</a>
from <span class="vcard"><a class="email" href="mailto:yoav@yoav.ws" title="Yoav Weiss <yoav@yoav.ws>"> <span class="fn">Yoav Weiss</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=157988#c5">comment #5</a>)
<span class="quote">> Comment on <span class="bz_obsolete"><a href="attachment.cgi?id=279872&action=diff" name="attach_279872" title="Patch">attachment 279872</a> <a href="attachment.cgi?id=279872&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=279872&action=review">https://bugs.webkit.org/attachment.cgi?id=279872&action=review</a>
>
> > LayoutTests/http/tests/preload/resources/single_download_preload.html:44
> > +<span>PASS - this text is here just so that the browser will download the font.</span>
>
> I'm not sure PASS is a good thing to have here.</span >
Removed it
<span class="quote">>
> > LayoutTests/http/tests/preload/single_download_preload_runner.html:13
> > + assert_equals(data, 10);
>
> Is there a way to have this print something to the expectations? This value
> is what the test is confirming, and it's hard to tell just by glancing at
> the test.</span >
Actually the expectation is not needed for testharness tests. I deleted it and added a description on the assert. Let me know if it's clear enough.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>