[Webkit-unassigned] [Bug 156147] [JSC] implement async functions proposal

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=156147

Yusuke Suzuki <utatane.tea at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #279829|review?, commit-queue?      |review+, commit-queue-
              Flags|                            |

--- Comment #87 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 279829
  --> https://bugs.webkit.org/attachment.cgi?id=279829
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=279829&action=review

Looks good to me.
Before landing, please ensure that JSBench (you can run it with run-jsc-benchmark) does not has regression,
since JSBench is good for measuring the code loading (parser) performance.

> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:656
> +    if (SourceParseMode::ArrowFunctionMode == parseMode || SourceParseMode::AsyncArrowFunctionBodyMode == parseMode || SourceParseMode::AsyncArrowFunctionMode == parseMode) {

Please add a comment about why AsyncArrowFunctionBodyMode is listed here.
(comment about the system that async arrow function body looks up the arrow function's context).

> Source/JavaScriptCore/parser/ASTBuilder.h:386
> +            usesArrowFunction();

Is this usesArrowFunction() here correct? These functions are not arrow functions, right?
If the body is specially handled, please add a comment about how the body is handled.

> Source/JavaScriptCore/parser/Parser.cpp:3541
> +            goto parseProperty;

Is it safe for `async hello: value` property?
I think we need to chek !isAsyncMethod in match(COLON) phase to avoid it.
And please add the test to ensure that JSC makes `async hello: value` case SyntaxError.

> Source/JavaScriptCore/parser/Parser.h:1579
> +        ASSERT(false);

should be RELEASE_ASSERT_NOT_REACHED()

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160526/482fc872/attachment.html>