<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:utatane.tea@gmail.com" title="Yusuke Suzuki <utatane.tea@gmail.com>"> <span class="fn">Yusuke Suzuki</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [JSC] implement async functions proposal"
href="https://bugs.webkit.org/show_bug.cgi?id=156147">bug 156147</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #279829 Flags</td>
<td>review?, commit-queue?
</td>
<td>review+, commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [JSC] implement async functions proposal"
href="https://bugs.webkit.org/show_bug.cgi?id=156147#c87">Comment # 87</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [JSC] implement async functions proposal"
href="https://bugs.webkit.org/show_bug.cgi?id=156147">bug 156147</a>
from <span class="vcard"><a class="email" href="mailto:utatane.tea@gmail.com" title="Yusuke Suzuki <utatane.tea@gmail.com>"> <span class="fn">Yusuke Suzuki</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=279829&action=diff" name="attach_279829" title="Patch">attachment 279829</a> <a href="attachment.cgi?id=279829&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=279829&action=review">https://bugs.webkit.org/attachment.cgi?id=279829&action=review</a>
Looks good to me.
Before landing, please ensure that JSBench (you can run it with run-jsc-benchmark) does not has regression,
since JSBench is good for measuring the code loading (parser) performance.
<span class="quote">> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:656
> + if (SourceParseMode::ArrowFunctionMode == parseMode || SourceParseMode::AsyncArrowFunctionBodyMode == parseMode || SourceParseMode::AsyncArrowFunctionMode == parseMode) {</span >
Please add a comment about why AsyncArrowFunctionBodyMode is listed here.
(comment about the system that async arrow function body looks up the arrow function's context).
<span class="quote">> Source/JavaScriptCore/parser/ASTBuilder.h:386
> + usesArrowFunction();</span >
Is this usesArrowFunction() here correct? These functions are not arrow functions, right?
If the body is specially handled, please add a comment about how the body is handled.
<span class="quote">> Source/JavaScriptCore/parser/Parser.cpp:3541
> + goto parseProperty;</span >
Is it safe for `async hello: value` property?
I think we need to chek !isAsyncMethod in match(COLON) phase to avoid it.
And please add the test to ensure that JSC makes `async hello: value` case SyntaxError.
<span class="quote">> Source/JavaScriptCore/parser/Parser.h:1579
> + ASSERT(false);</span >
should be RELEASE_ASSERT_NOT_REACHED()</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>