[Webkit-unassigned] [Bug 158105] Capture screenshot on timeout in webkitpy

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=158105

--- Comment #5 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
Comment on attachment 279858
  --> https://bugs.webkit.org/attachment.cgi?id=279858
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=279858&action=review

> Tools/Scripts/webkitpy/benchmark_runner/utils.py:63
>      def handle_timeout(self, signum, frame):
> +        self.capture_screenshot()
>          raise TimeoutError(self.error_message)

Maybe capture_screenshot() can be implemented as an abstract method of the class BrowserDriver() (at browser_driver.py) that just passes, and then implement the platform specific code in each one of the OS drivers? (for Mac it will be osx_browser_driver.py).
I can follow up with an implementation for GTK (gtk_browser_driver.py) after this patch lands.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160526/c01a37ad/attachment.html>