<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED - Capture screenshot on timeout in webkitpy"
href="https://bugs.webkit.org/show_bug.cgi?id=158105#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED - Capture screenshot on timeout in webkitpy"
href="https://bugs.webkit.org/show_bug.cgi?id=158105">bug 158105</a>
from <span class="vcard"><a class="email" href="mailto:clopez@igalia.com" title="Carlos Alberto Lopez Perez <clopez@igalia.com>"> <span class="fn">Carlos Alberto Lopez Perez</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=279858&action=diff" name="attach_279858" title="Proposed patch">attachment 279858</a> <a href="attachment.cgi?id=279858&action=edit" title="Proposed patch">[details]</a></span>
Proposed patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=279858&action=review">https://bugs.webkit.org/attachment.cgi?id=279858&action=review</a>
<span class="quote">> Tools/Scripts/webkitpy/benchmark_runner/utils.py:63
> def handle_timeout(self, signum, frame):
> + self.capture_screenshot()
> raise TimeoutError(self.error_message)</span >
Maybe capture_screenshot() can be implemented as an abstract method of the class BrowserDriver() (at browser_driver.py) that just passes, and then implement the platform specific code in each one of the OS drivers? (for Mac it will be osx_browser_driver.py).
I can follow up with an implementation for GTK (gtk_browser_driver.py) after this patch lands.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>