[Webkit-unassigned] [Bug 156595] Display failing JSC stress tests in buildbot dashboard

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=156595

Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #279723|review?                     |review+
              Flags|                            |

--- Comment #19 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 279723
  --> https://bugs.webkit.org/attachment.cgi?id=279723
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=279723&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:114
> +                        var URL = mostRecentFinishedIteration.queue.buildbot.javaScriptCoreTestStdioURLForIteration(mostRecentFinishedIteration, failedStep.name);

WebKit style is to have local variable names start with lower case, so this one should be "url", not "URL".

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:257
> +            var elementType = (additionalTextTarget) ? "a" : "span";

I wouldn't have added parentheses around additionalTextTarget, as it is already so easy to figure out wha the condition is.

We don't have a specific style rule about this, but we have that in an example in the style guide ("return condition ? 1 : 0;")

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:108
> +                    } else if (failedStep.name in ["jscore-test", "webkit-32bit-jsc-test", "webkit-jsc-cloop-test"]) {

In a separate patch, we should also present a better popover when there are both layout test and jsc failures.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160525/5c58b263/attachment.html>