<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:ap@webkit.org" title="Alexey Proskuryakov <ap@webkit.org>"> <span class="fn">Alexey Proskuryakov</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Display failing JSC stress tests in buildbot dashboard"
href="https://bugs.webkit.org/show_bug.cgi?id=156595">bug 156595</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #279723 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Display failing JSC stress tests in buildbot dashboard"
href="https://bugs.webkit.org/show_bug.cgi?id=156595#c19">Comment # 19</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Display failing JSC stress tests in buildbot dashboard"
href="https://bugs.webkit.org/show_bug.cgi?id=156595">bug 156595</a>
from <span class="vcard"><a class="email" href="mailto:ap@webkit.org" title="Alexey Proskuryakov <ap@webkit.org>"> <span class="fn">Alexey Proskuryakov</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=279723&action=diff" name="attach_279723" title="Patch">attachment 279723</a> <a href="attachment.cgi?id=279723&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=279723&action=review">https://bugs.webkit.org/attachment.cgi?id=279723&action=review</a>
<span class="quote">> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:114
> + var URL = mostRecentFinishedIteration.queue.buildbot.javaScriptCoreTestStdioURLForIteration(mostRecentFinishedIteration, failedStep.name);</span >
WebKit style is to have local variable names start with lower case, so this one should be "url", not "URL".
<span class="quote">> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:257
> + var elementType = (additionalTextTarget) ? "a" : "span";</span >
I wouldn't have added parentheses around additionalTextTarget, as it is already so easy to figure out wha the condition is.
We don't have a specific style rule about this, but we have that in an example in the style guide ("return condition ? 1 : 0;")
<span class="quote">> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:108
> + } else if (failedStep.name in ["jscore-test", "webkit-32bit-jsc-test", "webkit-jsc-cloop-test"]) {</span >
In a separate patch, we should also present a better popover when there are both layout test and jsc failures.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>