[Webkit-unassigned] [Bug 157995] [iOS] Allow clients to set the type of an input field

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=157995

mitz at webkit.org <mitz at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #279580|review?                     |review+
              Flags|                            |

--- Comment #2 from mitz at webkit.org <mitz at webkit.org> ---
Comment on attachment 279580
  --> https://bugs.webkit.org/attachment.cgi?id=279580
[iOS] Allow clients to set the type of an input field.txt

View in context: https://bugs.webkit.org/attachment.cgi?id=279580&action=review

> Source/WebKit2/ChangeLog:3
> +        [iOS] Allow clients to set the type of an input field

Perhaps “override” instead of “set”?

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:366
> +    [_contentView reloadInputViews];

It’s unfortunate that if the client sets the text content type and then immediately sets the input view, we’ll reload input views twice. Might be good to follow up with a change that coalesces these if possible.

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:3032
> +    if (NSString *textContentType = [_formInputSession textContentType])
> +        [_traits setTextContentType:textContentType];

A little strange to let the switch statement above set the type only to have it set to something else here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160523/8e6d7dbb/attachment.html>