<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:mitz@webkit.org" title="mitz@webkit.org <mitz@webkit.org>"> <span class="fn">mitz@webkit.org</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [iOS] Allow clients to set the type of an input field"
href="https://bugs.webkit.org/show_bug.cgi?id=157995">bug 157995</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #279580 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [iOS] Allow clients to set the type of an input field"
href="https://bugs.webkit.org/show_bug.cgi?id=157995#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [iOS] Allow clients to set the type of an input field"
href="https://bugs.webkit.org/show_bug.cgi?id=157995">bug 157995</a>
from <span class="vcard"><a class="email" href="mailto:mitz@webkit.org" title="mitz@webkit.org <mitz@webkit.org>"> <span class="fn">mitz@webkit.org</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=279580&action=diff" name="attach_279580" title="[iOS] Allow clients to set the type of an input field.txt">attachment 279580</a> <a href="attachment.cgi?id=279580&action=edit" title="[iOS] Allow clients to set the type of an input field.txt">[details]</a></span>
[iOS] Allow clients to set the type of an input field.txt
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=279580&action=review">https://bugs.webkit.org/attachment.cgi?id=279580&action=review</a>
<span class="quote">> Source/WebKit2/ChangeLog:3
> + [iOS] Allow clients to set the type of an input field</span >
Perhaps “override” instead of “set”?
<span class="quote">> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:366
> + [_contentView reloadInputViews];</span >
It’s unfortunate that if the client sets the text content type and then immediately sets the input view, we’ll reload input views twice. Might be good to follow up with a change that coalesces these if possible.
<span class="quote">> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:3032
> + if (NSString *textContentType = [_formInputSession textContentType])
> + [_traits setTextContentType:textContentType];</span >
A little strange to let the switch statement above set the type only to have it set to something else here.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>