[Webkit-unassigned] [Bug 157763] Make handleAcceptedCandidate a public function

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=157763

--- Comment #2 from Conrad Shultz <conrad_shultz at apple.com> ---
Comment on attachment 279057
  --> https://bugs.webkit.org/attachment.cgi?id=279057
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=279057&action=review

Looks good to me, but I'm not a reviewer unfortunately.

> Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm:1201
>      [m_webView showCandidates:candidates forString:m_paragraphContextForCandidateRequest.get() inRect:rectForSelectionCandidates forSelectedRange:m_rangeForCandidates view:m_webView completionHandler:[weakEditor](NSTextCheckingResult *acceptedCandidate) {

Seems like weakEditor is no longer used.

> Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm:1202
> +        dispatch_async(dispatch_get_main_queue(), ^{ });

Why is this necessary? Can you pass nil as the completion handler (or, failing that, an empty block)?

> Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm:1224
>                  [(WebHTMLView *)view _setSoftSpaceRange:softSpaceRange];

Looks like you could declare softSpaceRange only in the case where the replacement ends in space.

Does this properly handle a case where a replacement ends in multiple spaces?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160517/f370a097/attachment-0001.html>