<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Make handleAcceptedCandidate a public function"
href="https://bugs.webkit.org/show_bug.cgi?id=157763#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Make handleAcceptedCandidate a public function"
href="https://bugs.webkit.org/show_bug.cgi?id=157763">bug 157763</a>
from <span class="vcard"><a class="email" href="mailto:conrad_shultz@apple.com" title="Conrad Shultz <conrad_shultz@apple.com>"> <span class="fn">Conrad Shultz</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=279057&action=diff" name="attach_279057" title="Patch">attachment 279057</a> <a href="attachment.cgi?id=279057&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=279057&action=review">https://bugs.webkit.org/attachment.cgi?id=279057&action=review</a>
Looks good to me, but I'm not a reviewer unfortunately.
<span class="quote">> Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm:1201
> [m_webView showCandidates:candidates forString:m_paragraphContextForCandidateRequest.get() inRect:rectForSelectionCandidates forSelectedRange:m_rangeForCandidates view:m_webView completionHandler:[weakEditor](NSTextCheckingResult *acceptedCandidate) {</span >
Seems like weakEditor is no longer used.
<span class="quote">> Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm:1202
> + dispatch_async(dispatch_get_main_queue(), ^{ });</span >
Why is this necessary? Can you pass nil as the completion handler (or, failing that, an empty block)?
<span class="quote">> Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm:1224
> [(WebHTMLView *)view _setSoftSpaceRange:softSpaceRange];</span >
Looks like you could declare softSpaceRange only in the case where the replacement ends in space.
Does this properly handle a case where a replacement ends in multiple spaces?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>