[Webkit-unassigned] [Bug 157789] Cascading order for !important properties in ::slotted and ::host rules is incorrect

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 17 12:32:49 PDT 2016


https://bugs.webkit.org/show_bug.cgi?id=157789

--- Comment #8 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 279122
  --> https://bugs.webkit.org/attachment.cgi?id=279122
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=279122&action=review

> Source/WebCore/css/StyleResolver.cpp:2414
> +static bool hasImportantProperties(const StyleProperties& properties)
> +{
> +    for (unsigned i = 0, count = properties.propertyCount(); i < count; ++i) {
> +        if (properties.propertyAt(i).isImportant())
> +            return true;
> +    }
> +    return false;
> +}

It seems a bit inefficient to call propertyAt just to find an important property.
Can we add a new helper method on StyleProperty instead?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160517/97e82c3c/attachment.html>


More information about the webkit-unassigned mailing list