<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Cascading order for !important properties in ::slotted and ::host rules is incorrect"
href="https://bugs.webkit.org/show_bug.cgi?id=157789#c8">Comment # 8</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Cascading order for !important properties in ::slotted and ::host rules is incorrect"
href="https://bugs.webkit.org/show_bug.cgi?id=157789">bug 157789</a>
from <span class="vcard"><a class="email" href="mailto:rniwa@webkit.org" title="Ryosuke Niwa <rniwa@webkit.org>"> <span class="fn">Ryosuke Niwa</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=279122&action=diff" name="attach_279122" title="patch">attachment 279122</a> <a href="attachment.cgi?id=279122&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=279122&action=review">https://bugs.webkit.org/attachment.cgi?id=279122&action=review</a>
<span class="quote">> Source/WebCore/css/StyleResolver.cpp:2414
> +static bool hasImportantProperties(const StyleProperties& properties)
> +{
> + for (unsigned i = 0, count = properties.propertyCount(); i < count; ++i) {
> + if (properties.propertyAt(i).isImportant())
> + return true;
> + }
> + return false;
> +}</span >
It seems a bit inefficient to call propertyAt just to find an important property.
Can we add a new helper method on StyleProperty instead?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>