[Webkit-unassigned] [Bug 155228] [GStreamer] webaudio playback improvements

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=155228

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #273416|review?                     |review+
              Flags|                            |

--- Comment #5 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 273416
  --> https://bugs.webkit.org/attachment.cgi?id=273416
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=273416&action=review

> Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:232
> +        g_object_set(appsrc, "max-bytes", static_cast<guint64>(2 * priv->bufferSize), "block", TRUE,

Indeed, we always have to cast ints when using g_object_set with anything other than a gint, as the compiler cannot know the right size on its own. This would ideally be committed separately to draw attention to it, since it's a crash fix snuck into a performance improvement commit.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160517/3b26f404/attachment.html>