<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer] webaudio playback improvements"
href="https://bugs.webkit.org/show_bug.cgi?id=155228">bug 155228</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #273416 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer] webaudio playback improvements"
href="https://bugs.webkit.org/show_bug.cgi?id=155228#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer] webaudio playback improvements"
href="https://bugs.webkit.org/show_bug.cgi?id=155228">bug 155228</a>
from <span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=273416&action=diff" name="attach_273416" title="patch">attachment 273416</a> <a href="attachment.cgi?id=273416&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=273416&action=review">https://bugs.webkit.org/attachment.cgi?id=273416&action=review</a>
<span class="quote">> Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:232
> + g_object_set(appsrc, "max-bytes", static_cast<guint64>(2 * priv->bufferSize), "block", TRUE,</span >
Indeed, we always have to cast ints when using g_object_set with anything other than a gint, as the compiler cannot know the right size on its own. This would ideally be committed separately to draw attention to it, since it's a crash fix snuck into a performance improvement commit.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>