[Webkit-unassigned] [Bug 157741] JSC: DFG::SpeculativeJIT::compile special case for MIPS for PutByValWithThis

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=157741

--- Comment #11 from Julien Brianceau <jbriance at cisco.com> ---
Comment on attachment 279023
  --> https://bugs.webkit.org/attachment.cgi?id=279023
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=279023&action=review

Looks good to me

>>> Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp:2931
>>> +        m_jit.move(TrustedImm32(0), GPRInfo::argumentGPR1);
>> 
>> Is this because 64-bit values need to be aligned on even registers?
> 
> That was my reasoning. Though looking at the code generated by gcc for operationPutByValWithThisStrict(), even in -O0 it never accesses $a1 or the corresponding address on the stack, so I will remove that one line in a subsequent version of the patch. The next value (which is 64 bits) definitely needs to be on $a2 and $a3 though (and accordingly, 4 stack entries need to be reserved for the values we put in $a0-$a3, though they don't need to be set by the caller.

I agree, there is no need to set $a1 to 0 here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160517/a91353ac/attachment.html>