<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - JSC: DFG::SpeculativeJIT::compile special case for MIPS for PutByValWithThis"
href="https://bugs.webkit.org/show_bug.cgi?id=157741#c11">Comment # 11</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - JSC: DFG::SpeculativeJIT::compile special case for MIPS for PutByValWithThis"
href="https://bugs.webkit.org/show_bug.cgi?id=157741">bug 157741</a>
from <span class="vcard"><a class="email" href="mailto:jbriance@cisco.com" title="Julien Brianceau <jbriance@cisco.com>"> <span class="fn">Julien Brianceau</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=279023&action=diff" name="attach_279023" title="Patch">attachment 279023</a> <a href="attachment.cgi?id=279023&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=279023&action=review">https://bugs.webkit.org/attachment.cgi?id=279023&action=review</a>
Looks good to me
<span class="quote">>>> Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp:2931
>>> + m_jit.move(TrustedImm32(0), GPRInfo::argumentGPR1);
>>
>> Is this because 64-bit values need to be aligned on even registers?
>
> That was my reasoning. Though looking at the code generated by gcc for operationPutByValWithThisStrict(), even in -O0 it never accesses $a1 or the corresponding address on the stack, so I will remove that one line in a subsequent version of the patch. The next value (which is 64 bits) definitely needs to be on $a2 and $a3 though (and accordingly, 4 stack entries need to be reserved for the values we put in $a0-$a3, though they don't need to be set by the caller.</span >
I agree, there is no need to set $a1 to 0 here.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>