[Webkit-unassigned] [Bug 157750] New: BitmapImage::checkForSolidColor() cleanup

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 16 13:29:01 PDT 2016


            Bug ID: 157750
           Summary: BitmapImage::checkForSolidColor() cleanup
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Images
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: sabouhallawa at apple.com

This function is repeated in two files: BitmapImageCG.cpp and BitmapImageCairo.cpp. We need to move this function to BitmapImage.cpp and we need to create a new platform dependent function NativeImage::solidColor(). This later function returns an Optional<Color> given a NativeImagePtr. It is going to be called from the merged BitmapImage::checkForSolidColor().

Also we need to simplify the state of the solidColor in BitmapImage. Currently its state is controlled by three members: m_checkedForSolidColor, m_isSolidColor and m_solidColor. We can simplify that by getting rid of the two flags and changing the type of m_solidColor to be Optional<Color>.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160516/b4e65c73/attachment.html>

More information about the webkit-unassigned mailing list