<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW - BitmapImage::checkForSolidColor() cleanup"
href="https://bugs.webkit.org/show_bug.cgi?id=157750">157750</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>BitmapImage::checkForSolidColor() cleanup
</td>
</tr>
<tr>
<th>Classification</th>
<td>Unclassified
</td>
</tr>
<tr>
<th>Product</th>
<td>WebKit
</td>
</tr>
<tr>
<th>Version</th>
<td>WebKit Nightly Build
</td>
</tr>
<tr>
<th>Hardware</th>
<td>Unspecified
</td>
</tr>
<tr>
<th>OS</th>
<td>Unspecified
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>Normal
</td>
</tr>
<tr>
<th>Priority</th>
<td>P2
</td>
</tr>
<tr>
<th>Component</th>
<td>Images
</td>
</tr>
<tr>
<th>Assignee</th>
<td>webkit-unassigned@lists.webkit.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>sabouhallawa@apple.com
</td>
</tr></table>
<p>
<div>
<pre>This function is repeated in two files: BitmapImageCG.cpp and BitmapImageCairo.cpp. We need to move this function to BitmapImage.cpp and we need to create a new platform dependent function NativeImage::solidColor(). This later function returns an Optional<Color> given a NativeImagePtr. It is going to be called from the merged BitmapImage::checkForSolidColor().
Also we need to simplify the state of the solidColor in BitmapImage. Currently its state is controlled by three members: m_checkedForSolidColor, m_isSolidColor and m_solidColor. We can simplify that by getting rid of the two flags and changing the type of m_solidColor to be Optional<Color>.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>